Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete transient in any case #520

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Delete transient in any case #520

merged 1 commit into from
Mar 18, 2024

Conversation

arunshenoy99
Copy link
Member

@arunshenoy99 arunshenoy99 commented Mar 12, 2024 •
edited by officiallygod
Loading

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 added Code Review The PR is in Code Review QA This PR is in QA and removed Code Review The PR is in Code Review labels Mar 12, 2024
officiallygod
officiallygod approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@avneet-raj avneet-raj added Ready to merge The Code Review and QA is done and it can be merged. and removed QA This PR is in QA labels Mar 18, 2024
@arunshenoy99 arunshenoy99 merged commit 274ee29 into trunk Mar 18, 2024
6 of 10 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/sitegen-transient branch March 18, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunshenoy99 @officiallygod @avneet-raj