Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Fork Screen if Sitegen Capability is disabled and fix back button issue #500

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Skip Fork Screen if Sitegen Capability is disabled and fix back button issue #500

merged 2 commits into from
Mar 4, 2024

Conversation

girish-lokapure
Copy link
Contributor

  • added capability check in state handler, removes the fork step if the flow is ecom or sitebuild
  • this fixes the back button issue as well

@girish-lokapure girish-lokapure self-assigned this Feb 29, 2024
@girish-lokapure girish-lokapure added the Code Review The PR is in Code Review label Feb 29, 2024
ajayadav09
ajayadav09 reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@ajayadav09 ajayadav09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. works as expected

@diwanshuster diwanshuster merged commit 6836f95 into trunk Mar 4, 2024
2 of 5 checks passed
@diwanshuster diwanshuster deleted the PRESS2-1808 branch March 4, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajayadav09 ajayadav09 ajayadav09 left review comments

@diwanshuster diwanshuster diwanshuster approved these changes

@arunshenoy99 arunshenoy99 Awaiting requested review from arunshenoy99

Assignees

@girish-lokapure girish-lokapure

Labels
Code Review The PR is in Code Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@girish-lokapure @ajayadav09 @diwanshuster