Enhance AI Generation time #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
officiallygod
added
Code Review
ajayadav09
reviewed
Mar 1, 2024
| setCurrentOnboardingData( currentData ); | ||
|
|
||
| // Get the homepages and set that in flow | ||
| const response = await getHomepages( |
There was a problem hiding this comment.
will the error screen show up on the site-logo pag
also will we be calling the homepage on preview step if we already have it in the flowData ?
There was a problem hiding this comment.
-
No error will show up on Site logo page
and Hompage is just made on Exp step as we check if the flow has data before making a request in preview step it ensures the request is actually only made once however if homepage fails in exp step it is retried again in preview step where the error state is shown if it never works.
officiallygod
added
QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: