Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove building step with error screen UI #478

Merged
merged 21 commits into from
Feb 28, 2024

Conversation

ajayadav09
Copy link
Contributor

@ajayadav09 ajayadav09 commented Feb 21, 2024

Removed building step
Moved all apis to the experience page
changed the Error state logic to call the failed apis only by @girish-lokapure

PR for data: newfold-labs/wp-module-onboarding-data#53

@ajayadav09 ajayadav09 mentioned this pull request Feb 21, 2024
@officiallygod officiallygod added needs-code-improvement Functionality works but code can be improved. WIP PR is a Work in Progress and not ready for review. and removed needs-code-improvement Functionality works but code can be improved. labels Feb 21, 2024
@girish-lokapure girish-lokapure added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Feb 23, 2024
@officiallygod officiallygod merged commit e59a7ef into trunk Feb 28, 2024
2 of 5 checks passed
@officiallygod officiallygod deleted the remove-building-step-with-error-ui branch February 28, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review The PR is in Code Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants