-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove building step with error screen UI #478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-step-with-error-ui
Closed
officiallygod
added
needs-code-improvement
Functionality works but code can be improved.
WIP
PR is a Work in Progress and not ready for review.
and removed
needs-code-improvement
Functionality works but code can be improved.
labels
Feb 21, 2024
girish-lokapure
added
Code Review
The PR is in Code Review
and removed
WIP
PR is a Work in Progress and not ready for review.
labels
Feb 23, 2024
…oarding into remove-building-step-with-error-ui
officiallygod
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed building step
Moved all apis to the experience page
changed the Error state logic to call the failed apis only by @girish-lokapure
PR for data: newfold-labs/wp-module-onboarding-data#53