Merge pull request #496 from newfold-labs/fix/some-issue

Fix Duplicate UseEffect
newfold-labs · Feb 28, 2024 · e87b1e3 · e87b1e3
2 parents 1473d95 + d64019d
commit e87b1e3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteGen/index.js b/src/OnboardingSPA/components/NewfoldInterfaceSkeleton/SiteGen/index.js
@@ -45,10 +45,6 @@ const ThemedNewfoldInterfaceSkeleton = themeToggleHOC(
 
 const SiteGen = () => {
 	const [ failedApi, setFailedApi ] = useState( [] );
-
-	useEffect( () => {
-		document.body.classList.add( `nfd-brand-${ newfoldBrand }` );
-	}, [ newfoldBrand ] );
 	const location = useLocation();
 
 	const {

diff --git a/src/OnboardingSPA/steps/SiteGen/SiteLogo/index.js b/src/OnboardingSPA/steps/SiteGen/SiteLogo/index.js
@@ -62,7 +62,7 @@ const SiteGenSiteLogo = () => {
 		setSiteLogo( undefined );
 		setIsFooterNavAllowed( false );
 		trackOnboardingEvent(
-			new OnboardingEvent( ACTION_SITEGEN_LOGO_SKIPPED, {
+			new OnboardingEvent( ACTION_SITEGEN_LOGO_SKIPPED, undefined, {
 				source: SITEGEN_FLOW,
 			} )
 		);

diff --git a/src/OnboardingSPA/steps/SiteGen/SocialMedia/index.js b/src/OnboardingSPA/steps/SiteGen/SocialMedia/index.js
@@ -68,9 +68,13 @@ const SiteGenSiteSocialMedia = () => {
 
 	const trackSkipEvent = () => {
 		trackOnboardingEvent(
-			new OnboardingEvent( ACTION_SITEGEN_SOCIAL_CONNECT_SKIPPED, {
-				source: SITEGEN_FLOW,
-			} )
+			new OnboardingEvent(
+				ACTION_SITEGEN_SOCIAL_CONNECT_SKIPPED,
+				undefined,
+				{
+					source: SITEGEN_FLOW,
+				}
+			)
 		);
 	};