Skip to content

Commit

Permalink
linting fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ramyakrishnai committed Jun 24, 2024
1 parent 89f789a commit 199c5c6
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const SitegenEditorPatternsSidebar = () => {

useEffect( () => {
if ( ! ( activeTab?.home === 'favorites' ) ) {
setActiveTab( {
setActiveTab( {
name: 'all_versions',
title: (
<div className="nfd-onboarding-sidebar--sitegen-editor-patterns__header__tab-panel__versions-tab">
Expand Down Expand Up @@ -202,8 +202,8 @@ const SitegenEditorPatternsSidebar = () => {
</div>
);
} ),
} );
}
} );
}
}, [ homepages, activeHomepage, globalStyles ] );

Check warning on line 207 in src/OnboardingSPA/components/Sidebar/components/SitegenEditorPatterns/Sidebar.js

View workflow job for this annotation

GitHub Actions / Run Lint Checks

React Hook useEffect has missing dependencies: 'activeTab?.home', 'handleFavorite', and 'handlePreview'. Either include them or remove the dependency array

return (
Expand Down

0 comments on commit 199c5c6

Please sign in to comment.