Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added header and footer mapping in fallback #110

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

ajayadav09
Copy link
Contributor

@ajayadav09 ajayadav09 commented Aug 21, 2024

Proposed changes

PRESS0-1871:
https://jira.newfold.com/browse/PRESS0-1871

  • When the Primary Type and Secondary Type are not selected by the user, the header menu is rendered from the fallback theme and not fetched from the wonder-blocks. Since the fallback array did not have the header and footer the header-menu step in the DIY flow was breaking. Added the header and footer as a fallback.

  • On the wp-setup/step/design/homepage-menu step, the chosen header menu was not reflecting in the homepage layout block grammar instead the default was shown everytime. Updated the logic for that.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@ajayadav09 ajayadav09 added QA Ready for QA and removed Code Review Code Review labels Aug 27, 2024
@ajayadav09 ajayadav09 added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels Sep 4, 2024
@arunshenoy99 arunshenoy99 merged commit 8f09f94 into main Sep 10, 2024
2 of 3 checks passed
@arunshenoy99 arunshenoy99 deleted the PRESS0-1871-diy-header-menu-fix branch September 10, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants