Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the Sitegen Toast Survey #108

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Rename the Sitegen Toast Survey #108

merged 1 commit into from
Jul 31, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

This PR renames the Sitegen toast survey from wonder_start to wonder_start_sitegen_pulse.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 added the Code Review Code Review label Jul 26, 2024
@officiallygod officiallygod added QA Ready for QA and removed Code Review Code Review labels Jul 29, 2024
@arunshenoy99 arunshenoy99 added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels Jul 31, 2024
@arunshenoy99 arunshenoy99 merged commit fe195d1 into main Jul 31, 2024
2 checks passed
@arunshenoy99 arunshenoy99 deleted the enhance/rename-toast-event branch July 31, 2024 11:51
@officiallygod officiallygod mentioned this pull request Jul 31, 2024
Merged
9 tasks
@officiallygod
Copy link
Member

PRESS0-1771

@officiallygod officiallygod mentioned this pull request Jul 31, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @officiallygod