Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Path Issue in Extra Pages #106

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Fix Path Issue in Extra Pages #106

merged 9 commits into from
Jul 31, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Jul 25, 2024 •
edited
Loading

Proposed changes

This PR ensures the new links for extra pages are used from sitemap option.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Further comments

@officiallygod officiallygod added the In Progress The Development is currently going on. label Jul 25, 2024
@officiallygod officiallygod self-assigned this Jul 25, 2024
@officiallygod officiallygod added Code Review Code Review and removed In Progress The Development is currently going on. labels Jul 26, 2024
@officiallygod officiallygod added In Progress The Development is currently going on. and removed Code Review Code Review labels Jul 26, 2024
@officiallygod officiallygod added Code Review Code Review and removed In Progress The Development is currently going on. labels Jul 26, 2024
@officiallygod
Copy link
Member Author

PRESS0-1822

@officiallygod officiallygod added In Progress The Development is currently going on. and removed Code Review Code Review labels Jul 26, 2024
@officiallygod officiallygod added Code Review Code Review and removed In Progress The Development is currently going on. labels Jul 26, 2024
@arunshenoy99 arunshenoy99 added QA Ready for QA and removed Code Review Code Review labels Jul 26, 2024
@officiallygod officiallygod added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels Jul 31, 2024
@arunshenoy99 arunshenoy99 merged commit 73365be into main Jul 31, 2024
1 check passed
@arunshenoy99 arunshenoy99 deleted the fix/use-path-from-sitemap-data branch July 31, 2024 11:51
@officiallygod officiallygod mentioned this pull request Jul 31, 2024
Merged
9 tasks
@officiallygod officiallygod mentioned this pull request Jul 31, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@officiallygod @arunshenoy99