Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to track migration initiated from MFE #105

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Find a way to track migration initiated from MFE #105

merged 1 commit into from
Jul 24, 2024

Conversation

ramyakrishnai
Copy link
Contributor

@ramyakrishnai ramyakrishnai commented Jul 22, 2024 •
edited
Loading

Proposed changes

JIra: https://jira.newfold.com/browse/PRESS0-1764

  • Added mfe_migration_initiated event

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

officiallygod
officiallygod approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good ✅

@officiallygod officiallygod added the QA Ready for QA label Jul 23, 2024
@officiallygod
Copy link
Member

PRESS0-1764

@officiallygod officiallygod changed the title Update/press0-1764 | Find a way to track migration initiated from mfe Find a way to track migration initiated from MFE Jul 24, 2024
@ajayadav09 ajayadav09 added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels Jul 24, 2024
@ajayadav09 ajayadav09 merged commit 2e998cb into main Jul 24, 2024
3 of 4 checks passed
@diwanshuster diwanshuster removed the Ready to merge The PR is Code Reviewed and Tested and can be merged. label Jul 29, 2024
@arunshenoy99 arunshenoy99 deleted the update/press0-1764 branch September 11, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees

@ramyakrishnai ramyakrishnai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramyakrishnai @officiallygod @ajayadav09 @diwanshuster