Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split ai test into its own file, fix it, and enable testIsolation on all tests #34

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

This fixes the flaky theme test that sometimes fails. Also, adds testIsolation true so tests are more reliable and run from a blank slate and added some utility functions to use across tests in the module. Doing this, I also split the ai notification test into its own file so it was more manageable.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Nov 13, 2024
@circlecube circlecube merged commit a2703f2 into main Nov 13, 2024
6 checks passed
@circlecube circlecube deleted the update/tests-testIsolation branch November 13, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants