Verifying AI popup for six month old unlaunched sites - PS0-2221 #31
Conversation
| it( 'Is Accessible', () => { | ||
| cy.injectAxe(); | ||
| cy.wait( 1000 ); | ||
| cy.checkA11y( '.newfold-notifications-wrapper' ); | ||
| cy.checkA11y( '.ai-sitegen-modal__header' ); |
There was a problem hiding this comment.
It looks like this target was updated. I think it should remain as it was. It was looking at the notifications wrapper to ensure it is a11y compliant. I'm not sure why it would need to change, and I think targeting the ai sitegen modal header is not correct. I see the new notification is added, but it would load inside the existing wrapper, web plugin caught this since I don't believe it uses ai sitegen. Can we change this target back?
There was a problem hiding this comment.
I have reverted that to '.newfold-notifications-wrapper', Also have added alt text to images which were missing it.
|
This still looks to be failing the accessibility check on Web. |
… bluehost update notice id to reflect content rather than number for clarity lint auto-fixes in test file consistently use cypress env value for pluginId, no external support file necessary
this was changed in the previous commit because the onboarding screen is no longer in the app and it was updated to remove the page and content to reflect that.
|
I updated the tests and see that they are all passing. I noticed the web test was failing because the ai modal was displaying, which it should only display for bluehost. I updated the fixture to only add the ai notice on bluehost and skip those tests entirely unless bluehost too. I also cleaned the tests up a bit and updated the notice ids to be more descriptive and fixed the auto-lint issues. |
Proposed changes
https://jira.newfold.com/browse/PRESS0-2221 - Add Cypress Test for Modal Notification
Type of Change
Video
Checklist
Further comments