Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scripts Not Working for Notifications #29

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

This PR fixes the JavaScript inside the <script> tag of notifications not working as expected in the brand plugin React apps by rendering the styles and scripts where they are expected to be, instead of inside the notifications container.

Also refer: https://github.com/newfold-labs/laravel-hiive/pull/421

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Issue:

Screen.Recording.2024-09-04.at.2.21.04.AM.mov

Fix:

Screen.Recording.2024-09-04.at.2.24.04.AM.mov

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Member Author

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arunshenoy99 arunshenoy99 merged commit 81bb49e into main Sep 10, 2024
6 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/styles-and-scripts branch September 10, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants