-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single product page route/component to the marketplace #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve styles to fit new ui - use `classNames` package to handle custom styles. -
circlecube
approved these changes
Jun 3, 2024
circlecube
reviewed
Jun 17, 2024
@@ -31,6 +31,7 @@ jobs: | |||
module-repo: ${{ github.repository }} | |||
module-branch: ${{ needs.setup.outputs.branch }} | |||
plugin-repo: 'bluehost/bluehost-wordpress-plugin' | |||
plugin-branch: 'add/product-pages' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to remember to remove this line before merging or at least before tagging a release.
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A new single product page component to show more details about a product (within the app) when users click on a secondary CTA of a supporting product or are redirected to the single product page route with a proper product page ID.
index
/<NewfoldMarketplace />
) in their marketplace page instead of the one in the marketplace directory.useMatch
hook to determine which component to render (Product Page or Marketplace).Demo
Secondary CTA:
Loading state:
Error
state:
Type of Change
Checklist
Further comments
This PR aims to address part of this internal EPIC: https://jira.newfold.com/browse/PRESS0-441