sync to Yith products to CTB #52
Conversation
| } | ||
|
|
||
| // Show the filtered products on the page | ||
| showProducts(products) { |
There was a problem hiding this comment.
This supportsCTB shouldn't be needed. We can safely add the CTB attributes and the ctb module will detect whether it is supported or not.
FYI, there is a legacy ctb module and a newer global ctb module. They both will detect the same attributes and which one (if any) is supported.
| href="${product.primaryUrl}" | ||
| class="button button-primary nfd-ctb-btn" | ||
| ${supportsCTB && product.clickToBuyId ? 'data-action="load-nfd-ctb" data-ctb-id="' + product.clickToBuyId + '"' : ''}>Buy $${product.price}</a>`; | ||
| ${ | ||
| supportsCTB && product?.clickToBuyId |
There was a problem hiding this comment.
Here we can safely add the ctb attributes and don't need to check the supportsCTB value.
There was a problem hiding this comment.
This looks like just formatting changes now that the Yith IDs are not being included and mapped here.
The change here is that it will always add the ctb attributes to the products (without checking if the site supports CTB, which is what we want since the ctb modules manage that logic anyways), so we should include this, and it will add the attrs to all these products (YITH and others) properly all the time. The issue I believe was that this code checked if legacy ctb was supported, and that is being replaced for the most part by new global ctb - which this code didn't get updated to account for that.
Currently in the branded plugin, we are redirecting customers to the YITH plugin pages to purchase premium plugins. We need to use the YITH CTBs instead.
https://confluence.newfold.com/display/SF/Yith+Plugins
story : https://jira.newfold.com/browse/PRESS4-462