Skip to content

Commit

Permalink
Add linting to this module and fix linting issues, including the trai…
Browse files Browse the repository at this point in the history
…ling comma in a function call that doesn't work before PHP 7.3
  • Loading branch information
wpscholar committed Feb 1, 2023
1 parent ee55e69 commit 712851e
Show file tree
Hide file tree
Showing 9 changed files with 638 additions and 136 deletions.
63 changes: 63 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: Lint
on:
push:
branches:
- '**'
paths:
- '**.php'
pull_request:
types: [opened, edited, reopened, ready_for_review]
paths:
- '**.php'
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
cancel-in-progress: true

jobs:
phpcs:
name: Run PHP Code Sniffer
runs-on: ubuntu-latest
steps:

- name: Checkout
uses: actions/checkout@v3

# User PHP 7.4 here for compatibility with the WordPress codesniffer rules.
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '7.4'
coverage: none
tools: composer, cs2pr

- uses: technote-space/get-diff-action@v6
with:
SUFFIX_FILTER: .php

- name: Get Composer cache directory
id: composer-cache
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
if: "!! env.GIT_DIFF"

- name: Cache Composer vendor directory
uses: actions/cache@v3
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-
if: "!! env.GIT_DIFF"

- name: Validate composer.json and composer.lock
run: composer validate
if: "!! env.GIT_DIFF"

- name: Install dependencies
run: composer install --no-progress --optimize-autoloader --prefer-dist
if: "!! env.GIT_DIFF"

- name: Detecting PHP Code Standards Violations
run: vendor/bin/phpcs --standard=phpcs.xml -s ${{ env.GIT_DIFF }}
if: "!! env.GIT_DIFF"
4 changes: 2 additions & 2 deletions bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
function () {

register(
[
array(
'name' => 'marketplace',
'label' => __( 'Marketplace', 'newfold-module-marketplace' ),
'callback' => function ( Container $container ) {
new Marketplace( $container );
},
'isActive' => true,
'isHidden' => true,
]
)
);

}
Expand Down
16 changes: 16 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,23 @@
"bootstrap.php"
]
},
"config": {
"allow-plugins": {
"dealerdirect/phpcodesniffer-composer-installer": true
}
},
"require": {
"newfold-labs/wp-module-data": "^2.0.0"
},
"require-dev": {
"newfold-labs/wp-php-standards": "^1.2"
},
"scripts": {
"fix": [
"vendor/bin/phpcbf --standard=phpcs.xml ."
],
"lint": [
"vendor/bin/phpcs --standard=phpcs.xml -s ."
]
}
}
Loading

0 comments on commit 712851e

Please sign in to comment.