Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/tests #22

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Update/tests #22

merged 2 commits into from
Dec 16, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Updates tests with testIsolation see: PRESS10-29

Also in preparation for bluehost migration updated selectors to be more flexible in js and tests. Added a final modal slide with spinner to show when deactivation is finally triggered rather than simply closing and having the page wait to reload with deactivation.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Dec 12, 2024
@circlecube circlecube merged commit 8e366ed into main Dec 16, 2024
4 of 6 checks passed
@circlecube circlecube deleted the update/tests branch December 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants