Update/deactivation survey event #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this sends (No Input) or (Skipped) if the input field is blank so we can distinguish between them
wpscholar
approved these changes
Jun 5, 2024
* main: Added Drop down for temporary deactivation options in deactivation popup # Conflicts: # static/js/deactivation-survey.js
|
After merging the duration select field, I cleaned this up again. I'm not sure that we should send these as multiple events though, I wonder if we combine into one? @wpscholar |
* main: require the newfold-features script and only display enabled features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This updates the event input value to show the input text if it exists in all cases, or
(Skipped)if the skip button is used and the input is blank, or(No Input)if the input is empty.It also updates the logic to ensure the event submission is successful before proceeding to deactivate the plugin by returning the promise and deactivating in
then.See: PRESS0-1417
Type of Change
Checklist
Further comments