Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes: Lint, comment, rename #97

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

BrianHenryIE
Copy link
Contributor

Proposed changes

  • Mostly formatting and comments.
  • Code changes: add missing $throttle variable, use constant() when using constants.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@bradp
Copy link

bradp commented Sep 11, 2024

✅ Good to go once PHPCS passes

@BrianHenryIE BrianHenryIE merged commit 69d8f4e into main Sep 11, 2024
6 of 8 checks passed
@BrianHenryIE BrianHenryIE deleted the lint-comment-rename branch September 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants