Return early from ::installed_or_updated()
when no plugin in list
#95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When JavaScript is disabled, the plugin updater can be run with no plugins selected.
This results in an event which causes an error in Hiive
Type of Change
Don't fire the event if there is no plugin. Return early after the WordPress action is called:
if ( ... || ( ! empty( $options['plugins'] ) && empty( $options['plugins'][0] ) ) ) { return; }
Video
Checklist
Further comments
This is also handled in Hiive and I intend to address it in WP Core too.