Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR 76 bugs #92

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Fix PR 76 bugs #92

merged 7 commits into from
Jul 24, 2024

Conversation

BrianHenryIE
Copy link
Contributor

Proposed changes

  • Do not pass empty arrays to BatchQueue functions
  • Fix recursive call arguments after Hiive reconnect
  • Fix Content-Type and Accept header spelling
  • Handle HTTP 500 from Hiive which do not contain array with succeededEvents and failedEvents

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@BrianHenryIE BrianHenryIE merged commit 05458a2 into main Jul 24, 2024
4 of 8 checks passed
@BrianHenryIE BrianHenryIE deleted the fix/pr-76-bugs branch July 24, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpalani wpalani wpalani approved these changes

@wpscholar wpscholar wpscholar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrianHenryIE @wpscholar @wpalani