Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Commerce.php #75

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Update Commerce.php #75

merged 2 commits into from
Jun 18, 2024

Conversation

wpscholar
Copy link
Member

Label key should be the type

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpscholar
Update Commerce.php
267993c 
Label key should be the type
@wpscholar wpscholar self-assigned this Jun 7, 2024
@wpscholar wpscholar requested a review from BrianHenryIE June 7, 2024 19:41
@BrianHenryIE BrianHenryIE requested a review from circlecube June 18, 2024 17:15
@BrianHenryIE BrianHenryIE merged commit 9f83889 into main Jun 18, 2024
3 of 7 checks passed
@BrianHenryIE BrianHenryIE deleted the wpscholar-patch-1 branch June 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

@BrianHenryIE BrianHenryIE Awaiting requested review from BrianHenryIE

Assignees

@wpscholar wpscholar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpscholar @circlecube @BrianHenryIE