Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More testing changes, minor #113

Merged
merged 3 commits into from
Nov 19, 2024
Merged

More testing changes, minor #113

merged 3 commits into from
Nov 19, 2024

Conversation

BrianHenryIE
Copy link
Contributor

Proposed changes

  • Loosen the GitHub Actions dependency version strictness from shivammathur/[email protected] to shivammathur/setup-php@v2
  • Add --debug to the PHPUnit execution for verbose output during the Workflow

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Post-deployment Checklist

How can the change be verified?

  • The test workflow run for this PR should have a new line of output for every PHPUnit test run

Further comments

There is another change where I put parentheses around a boolean check but it was unnecessary.

@circlecube circlecube merged commit 7c1abaa into main Nov 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants