Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop retrying events #103

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Stop retrying events #103

merged 8 commits into from
Oct 17, 2024

Conversation

BrianHenryIE
Copy link
Contributor

Proposed changes

Too many events are being sent to Hiive.

  • Stop retrying events - i.e. remove events after attempted send
  • Reduce the number of events sent in a bulk request from 100 to 50
  • Stop sending these events from WordPress: page_view, wp_mail, plugin_updated
  • Add the WP brand name and plugin version to the user agent in the plugin

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

page_view or pageview ?

@wpscholar wpscholar requested a review from circlecube October 17, 2024 14:44
@BrianHenryIE BrianHenryIE merged commit fad23fc into main Oct 17, 2024
7 of 8 checks passed
@circlecube circlecube deleted the fix-queue branch October 17, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants