Disable event send retries

newfold-labs · Oct 17, 2024 · f7eee76 · f7eee76
1 parent eca143f
commit f7eee76
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/includes/EventManager.php b/includes/EventManager.php
@@ -211,6 +211,9 @@ protected function send_request_events( array $events ): void {
 			 */
 			$response = $subscriber->notify( $events );
 
+			// Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.
+			continue;
+
 			if ( ! ( $subscriber instanceof HiiveConnection ) ) {
 				continue;
 			}
@@ -260,6 +263,10 @@ public function send_saved_events_batch(): void {
 			 */
 			$response = $subscriber->notify( $events );
 
+			// Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.
+			$queue->remove( array_keys( $events ) );
+			continue;
+
 			if ( ! ( $subscriber instanceof HiiveConnection ) ) {
 				continue;
 			}

diff --git a/tests/phpunit/includes/EventManagerTest.php b/tests/phpunit/includes/EventManagerTest.php
@@ -157,6 +157,8 @@ public function test_init(): void {
 	 */
 	public function test_send_saved_events_happy_path(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$batch_queue_mock = Mockery::mock( BatchQueue::class );
 
 		\Patchwork\redefine(
@@ -225,6 +227,8 @@ function () use ( $batch_queue_mock ) {
 	 */
 	public function test_send_saved_events_happy_path_no_failed_events(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$batch_queue_mock = Mockery::mock( BatchQueue::class );
 
 		\Patchwork\redefine(
@@ -292,6 +296,8 @@ function () use ( $batch_queue_mock ) {
 	 */
 	public function test_send_saved_events_happy_path_no_successful_events(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$batch_queue_mock = Mockery::mock( BatchQueue::class );
 
 		\Patchwork\redefine(
@@ -359,6 +365,8 @@ function () use ( $batch_queue_mock ) {
 	 */
 	public function test_send_saved_events_wp_error_from_hiive_connection(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$batch_queue_mock = Mockery::mock( BatchQueue::class );
 
 		\Patchwork\redefine(
@@ -420,6 +428,8 @@ function () use ( $batch_queue_mock ) {
 	 */
 	public function test_send_saved_events_failures_from_hiive(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$batch_queue_mock = Mockery::mock( BatchQueue::class );
 
 		\Patchwork\redefine(
@@ -487,6 +497,8 @@ function () use ( $batch_queue_mock ) {
 	 */
 	public function test_shutdown_happy_path_no_failed_events(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$sut = new EventManager();
 
 		$event      = Mockery::mock( Event::class )->makePartial();
@@ -537,6 +549,8 @@ function () use ( $batch_queue_mock ) {
 	 */
 	public function test_shutdown_happy_path_with_failed_events(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$sut = new EventManager();
 
 		$event      = Mockery::mock( Event::class )->makePartial();
@@ -588,6 +602,8 @@ function () use ( $batch_queue_mock ) {
 	 */
 	public function test_shutdown_hiive_connection_wp_error(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$sut = new EventManager();
 
 		$event      = Mockery::mock( Event::class )->makePartial();
@@ -634,6 +650,8 @@ function () use ( $batch_queue_mock ) {
 	 */
 	public function test_shutdown_hiive_500_error(): void {
 
+		$this->markTestSkipped( 'Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.' );
+
 		$sut = new EventManager();
 
 		$event      = Mockery::mock( Event::class )->makePartial();