Move $queue->remove outside loop

newfold-labs · Oct 17, 2024 · 740b33c · 740b33c
1 parent ffb4dfa
commit 740b33c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/includes/EventManager.php b/includes/EventManager.php
@@ -272,7 +272,6 @@ public function send_saved_events_batch(): void {
 			$response = $subscriber->notify( $events );
 
 			// Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.
-			$queue->remove( array_keys( $events ) );
 			continue;
 
 			if ( ! ( $subscriber instanceof HiiveConnection ) ) {
@@ -294,5 +293,8 @@ public function send_saved_events_batch(): void {
 				$queue->release( array_keys( $response['failedEvents'] ) );
 			}
 		}
+
+		// Due to an unidentified bug causing events to be resent, we are temporarily disabling retries.
+		$queue->remove( array_keys( $events ) );
 	}
 }