Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test uninstall command #44

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

circlecube
Copy link
Member

Proposed changes

Just uninstall plugins we have installed in the test.

This updates a support method used in cypress tests. Currently, it uninstalls all plugins except those listed in the exclude list. I'm updating it to only uninstall the plugins that the test installs (Woo and the YITH payment plugins that are automatically installed with it). The module shouldn't have to keep a list of plugins to exclude.

I ran into issues with the bluehost plugin migration where even though the build slug will not be changed, in the testing env it can show up differently. This change fixes those issues and also will be more stable. The tests should clean up after themselves and not attempt to uninstall everything anyways - that approach is more brute force than we needed (and I think I'm to blame for it).

Added bonus: we won't have to maintain a long exclude list.

Also, a skip was removed earlier and I think we should keep it in place until we can extract that code out of the e-commerce module and bring it into this one. It makes no sense to have a test in this module for code that is not.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

added bonus: we wont have to maintain a long exclude list
@circlecube
Copy link
Member Author

Things look good in testing, the Web and Mojo plugins fail here because they skip the coming soon tests in favor of the coming soon test in the plugins.

This is because they both do not have the e-commerce module included and it changes coming soon. Eventually we'll get the coming soon code moved out of e-commerce module and into the coming soon module and that issue will be resolved, but for now we don't expect those two plugins to find coming soon tests and the workflows fails if it doesn't find tests for this module in the plugin.

@circlecube circlecube merged commit edcda7d into main Dec 13, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants