Remove Coming Soon Pre publish Modal CSS #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR removes unwanted CSS from Pre Publish Modal and uses existing classes instead.
Type of Change
Video
Screen.Recording.2024-08-28.at.11.17.09.AM.mov
Checklist
Further comments
Without External CSS:
With External CSS:
Not able to achieve exactly without using External CSS. We may have more similar looking modal with inline CSS, but it might not look good from code perspective. I'm not able to add the Launch icon, as it is disturbing the alignment of the buttons. Seems like icon buttons needs to be in a flex container. If we use flex, we need to use a media query for small screen sizes. For the other missing similarities like shadow/border, right alignment et., we need to use inline CSS.
Comment
People
Assignee:
varaprasad.maruboina
Vara Prasad Maruboina
Reporter:
emullins
Evan Mullins
Votes: 0 Vote for this issue
Watchers: 2
Stop watching this issue
Dates
Created: 01/Mar/24 5:48 PM
Updated: 1 minute ago
Automated Log Work
Your timer: Not startedA
Development
Create branch
Agile
View on Board