Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where coming soon isn't respecting mm_coming_soon #24

Merged
merged 24 commits into from
Jan 17, 2024
Merged

Fix issue where coming soon isn't respecting mm_coming_soon #24

merged 24 commits into from
Jan 17, 2024

Conversation

wpscholar
Copy link
Member

The notable changes in this PR:

  • If nfd_coming_soon doesn't exist, use mm_coming_soon as the fallback
  • If mm_coming_soon is changed, update nfd_coming_soon (or vice versa)
  • Run the upgrade routine once on the front end if it has never run before
  • Use real booleans for nfd_coming_soon and mm_coming_soon
  • Clean up logic for setting the nfd_coming_soon value.

@wpscholar
Use Node 18
e4e2f1e
@wpscholar
Change upgrade routine to make sure it runs with the new released ver…
c01e449 
…sion
@wpscholar
Add an isComingSoonActive function for internal use
e024693
@wpscholar
JS lint for webpack config
17fe09f
@wpscholar
Remove now defunct option_name
08fab57
@wpscholar
Bump version
6d69ba0
@wpscholar
Clean up scripts
f5f93a2
@wpscholar
Update JS dependencies
138047a
@wpscholar
Update build files
f200637
@wpscholar
Clean up logic for pre-publish modal
68e1675
@wpscholar
Update service to use real booleans when getting and setting options
32befd6
@wpscholar
Remove now defunct option_name
39d57d6
@wpscholar
Code formatting
86d5ad0
@wpscholar
Clean up logic for checking if coming soon is active
a2bca0b
@wpscholar
Add JetPack under construction logic
8540ece
@wpscholar
Add logic to set a default value for nfd_coming_soon and to sync that…
9549e6d 
… and the mm_coming_soon value
@wpscholar
Code formatting and general cleanup. Notably, we're running the initi…
cc432b3 
…al upgrade routine on the front-end only once (if it has never run before)
@wpscholar wpscholar added the bug Something isn't working label Jan 17, 2024
@wpscholar wpscholar requested a review from circlecube January 17, 2024 21:32
@wpscholar wpscholar self-assigned this Jan 17, 2024
@circlecube circlecube merged commit 224a336 into main Jan 17, 2024
1 check passed
@circlecube circlecube deleted the fix/coming-soon branch January 17, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@circlecube circlecube circlecube approved these changes

Assignees

@wpscholar wpscholar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpscholar @circlecube