Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin bar site status HTML content #22

Closed
wants to merge 1 commit into from

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Jan 12, 2024

No description provided.

Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we wanted the content to contain both states, so toggling the state would be much easier. The visibility of each state is controlled via CSS and the attribute data-coming-soon. This section is the associated styles that should control visibility: https://github.com/newfold-labs/wp-module-coming-soon/blob/main/includes/ComingSoon.php#L150-L158

Rather than only including the current content, I think just the test should be updated to check that the proper span is visible in the admin bar. #nfd-site-status-live and #nfd-site-status-coming-soon. That will make it less reliant on text content too (for translations and any other content customizations - since the text can be overridden from the plugin).

@wpalani
Copy link
Member Author

wpalani commented Jan 12, 2024

I think we wanted the content to contain both states, so toggling the state would be much easier. The visibility of each state is controlled via CSS and the attribute data-coming-soon. This section is the associated styles that should control visibility: https://github.com/newfold-labs/wp-module-coming-soon/blob/main/includes/ComingSoon.php#L150-L158

Rather than only including the current content, I think just the test should be updated to check that the proper span is visible in the admin bar. #nfd-site-status-live and #nfd-site-status-coming-soon. That will make it less reliant on text content too (for translations and any other content customizations - since the text can be overridden from the plugin).

Roger that! I'm closing this PR and will tackle the tests update in a different PR along-side other changes.

@wpalani wpalani closed this Jan 12, 2024
@wpalani wpalani deleted the fix/admin-bar-site-status branch January 12, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants