Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if as is default and size is set, update Component to represent the size #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

circlecube
Copy link
Member

No description provided.

@circlecube
Copy link
Member Author

I'm seeing that many Title components are being set to h1, but I think when we pass a specific size this component should adjust automatically to a matching heading level.

This will help with accessibility for heading levels - I'm seeing some cypress a11y checks fail because all the headings are coming out as h1. We could update all uses of this component to specify the as prop, but I think a better dev experience is to know that by setting size we also get a heading level according to the size, and if we want to specify something different, we should then also set the as prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant