Add alt verb to toggle accents from clothing

[Alkheemist]

About the PR

Added an alt verb to AddAccentClothingSystem that will allow you to toggle the active accent given by a piece of clothing. To do so, you must be wearing the clothing. This isn't stored, so unequipping and re-equipping will reapply the accent, but you can just toggle it off again afterwards.

Why / Balance

By popular request.

How to test

Put on accent clothing (cat ears are the most cringe based)
Say something
Alt click or right click and toggle the accent
Say something else

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None identified.

Changelog

🆑

• tweak: Clothing and items that apply accents can be toggled with alt click, so you can dress in style without worrying about intelligibility.

[Alkheemist]

Good catch, applied changes

[dvir001]

@Alkheemist Can you also add this to AddAccentPickupComponent?

Right now its just the caveman club

[Alkheemist]

actually digging into it... pickup code and the club is fundamentally broken

[Alkheemist]

OK, I've fixed it by adding in a new event (old one used for accentpickup was firing when the check for eligibility to pick up was made, not when the item was actually being picked up) and implementing the toggle for the club.

[Alkheemist]

anyone have any idea what's up with the 1 failing test?

[GreyMario]

anyone have any idea what's up with the 1 failing test?

frontier-station-14/Content.IntegrationTests/Tests/PrototypeSaveTest.cs

Line 184 in 8b707fd

public DataNode Write(ISerializationManager serializationManager, EntityUid value,

this is failing because your entity field isn't nullable

[Alkheemist]

I fixed the thing that was causing the failing test, ready for another review @dvir001

[whatston3]

Not a fan of this, in all honesty.

[dvir001]

Not a fan of this, in all honesty.

To be honest other forks just removed the accents fully from cloth then leaving the toggle (DeltaV, EE)
So this is more fine for general case.

[whatston3]

A few suggestions.

[whatston3]

Works fine, did a little cleanup:

"GettingPickedUpEvent" changed to "PickedUpEvent" - the item is already picked up. I think the hand can be found through the ContainerSystem.

Made the NF changes use the EntityManager proxy without the EntityManager reference for brevity, and removed "HasComp->RemComp", that check's already done by the function. The Add path I kept, since it's an early return.

Again, works without issue, good stuff.

Changes applied previously.