-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mercfab and NFSDfab QoL #2644
Open
blackknight954
wants to merge
24
commits into
new-frontiers-14:master
Choose a base branch
from
blackknight954:RubberMagazines
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mercfab and NFSDfab QoL #2644
blackknight954
wants to merge
24
commits into
new-frontiers-14:master
from
blackknight954:RubberMagazines
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR##
Adds shotgun slugs and rubber magazine variants to all ammo types for the NFSDfab and Mercfab
Why / Balance
Slugs are just a lower damage higher accuracy shotshell, rubbers are useful for not immediatly going to lethal rounds over small arguements when not having a disabler.
Also has been requested for awhile to have printable rubber mags be a static recipe.
How to test
Load environment
Spawn an NFSD/Mercfab
Observe the new ammunition
Media
Requirements
Breaking changes
Nothing I can think of, unless item listings in YML are crucial to the game functioning
Changelog
🆑
Added shotgun slugs and rubber magazines to the NFSD and Mercfabs