Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds colored light bulbs #2636

Merged
merged 14 commits into from
Jan 4, 2025
Merged

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Dec 30, 2024

About the PR

This PR adds new colored light bulbs based on the color types available in crystals. In addition to a mappable and discoverable box of bulbs.

Furthermore it adds construction graphs to allow the bulbs to be made in the same fashion as LED tubes.

It now also offers default fills for all lightbulbs, in addition to a two new lightbulb types to be better aligned with some tube types. These new lightbulbs have lathe recipes.

Why / Balance

When I was making the Nightlight shuttle I was dismayed at the lack of lighting options available when making "after hours" mood lighting for the bar. Adding colored bulbs, which can be used in additional devices, served as a great solution for this.

In short: More flexibility, more options.

How to test

Test bulbs in sockets.
Attempt to craft all bulbs.
Check box for proper bulb contents.
Double check lathe recipes.
Double check lightbulb illumination values to ensure that they're more or less where they should be.

Media

ss+(2024-12-30+at+11 05 14)
ss+(2024-12-26+at+03 41 34)
ss+(2024-12-31+at+11 01 30)

Requirements

Breaking changes

Changelog

🆑

  • add: Colored craftable lightbulbs and prefilled light strobes.!

@Temoffy
Copy link
Contributor

Temoffy commented Dec 30, 2024

could we also get light fill prototypes so we can map these bulbs?
and maybe some incandescent fills while you're there

@dustylens
Copy link
Contributor Author

That is something that could be done, yes. If this initial concept gets a thumbs up we can shovel another layer on top. In the meantime you can manually slot in any bulb colors that seem desirable.

@Temoffy
Copy link
Contributor

Temoffy commented Dec 30, 2024

Oh does that not count as a custom fill?

@dustylens
Copy link
Contributor Author

dustylens commented Dec 30, 2024

W... U. I mean, but.. Uh..

stares off into eternity

A good question for the maintainer people. In the meantime I'm working on a few other projects and I can certainly circle back to adding a few more bulbs here if the initial concept seems good to go.

At any rate I am confident to the extreme that the bulb question will be settled long before anything budges an inch on the mapping front.

@noldevin
Copy link

This is great, I was just thinking yesterday how it would be nice to be able to use colors with strobe lights

@dustylens
Copy link
Contributor Author

This is great, I was just thinking yesterday how it would be nice to be able to use colors with strobe lights

I created these lights for that specific purpose on a food shuttle I'm developing and I was really happy with the end result.

@noldevin
Copy link

This is great, I was just thinking yesterday how it would be nice to be able to use colors with strobe lights

I created these lights for that specific purpose on a food shuttle I'm developing and I was really happy with the end result.

I made a strobe next to a broken rtg engine as a warning when the door is unlocked and was disappointed it could only be white

@dustylens
Copy link
Contributor Author

Updated with new pre-filled strobes in addition to a new sodium and exterior light bulb.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Jan 4, 2025
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jan 4, 2025
@dvir001 dvir001 self-requested a review January 4, 2025 23:19
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 4, 2025
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light up

@dustylens
Copy link
Contributor Author

I see you made some light changes.

@dvir001 dvir001 merged commit de59bb6 into new-frontiers-14:master Jan 4, 2025
13 checks passed
FrontierATC added a commit that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants