Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds reinforced jug #2601

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Dec 22, 2024

About the PR

This PR adds a new researchable reinforced jug. As per discussion below it is a heavy jug that is carried in two hands and carries 400u. It fits into a dispenser.

It is locked behind t2 civilian tech for the moment, as there wasn't a very ideal t1 candidate. I feel like this may be overkill and will likely revisit it in the future if some addition tech options can be opened up in t1.

The chem dispenser comes with 10 of its 20 total jugs in the form of the reinforced versions for the most "often" used reagents to provide buffer solutions for those chems and to address one of the original concerns regarding resource deprivation in the early round.

Why / Balance

Today the issue of supplementary chem crates stored on some shuttles was raised. The general issue came down to desiring those restocks be removed in favor of vending machines, which itself was acknowledged to be an issue as vending machines have their own complications and baggage.

A simple solution would be to double the jugs present in the chem dispenser, essentially pre-loading the crate chems and removing the need for their mapping. However at present the last PR goal that I observed was to limit the initial storage capacity of the chem dispenser to 25 jugs.

As such the option of simply (adding a jug) (with) double jug capacity seemed reasonable.

How to test

Check research.
Check the lathe recipes.
Check the sprites, inspect fill states and general standard of quality of my horrific but well meaning artwork.

Media

ss+(2025-01-01+at+09 40 35)

Requirements

Breaking changes

Changelog

🆑

  • add: Adds reinforced jugs for expanded dispenser storage options.

@dvir001
Copy link
Contributor

dvir001 commented Dec 22, 2024

I think this should be a new jug if anything, not the base game one since its 200 on any fork.
Extended jug? idk.

Can also be a tier 2/1 tech thing that still not cost that much to print

initial storage capacity of the chem dispenser can probably be upped to 30 jugs honestly.

@dustylens
Copy link
Contributor Author

dustylens commented Dec 22, 2024

This isn't urgent and I'm heading out of town for a few days. So this one is fine to let settle and discuss.

I am receptive to creating a new jug type that works in dispensers. I think that would be a nice solution as well :)

My primary goals are

  • Removing round start shortages.
  • Meeting maintainer goal of removing extra crates where possible.
  • Finding a storage system that allows for the chem dispenser to have some additional quality of life. As 200u is a very small buffer.

Short discussion elicited some nice ideas. When I get back into town I'll whip them up. I'm going to keep this open as the primary PR but put it in draft for now so settle any ruffled feathers.

@dustylens dustylens marked this pull request as draft December 22, 2024 18:40
@MagnusCrowe
Copy link
Contributor

I suggested once that a new jug could be created with an increased volume as an incremental upgrade for the chem dispenser. It would be locked behind a very low level science, like the civ science that unlocks the huge spray bottle. I would also recommend that the huge jug be something that you can't fit in a standard inventory, make it huge or something. Maybe even force you to use 2 hands to handle it. The bluespace jug can get away with massive volume because it's made with space magic, but a mundane large jug would be big and unwieldly.

Also, if you're going to be selling jugs of chems, you may still want the 200u version.

@GreyMario
Copy link
Contributor

GreyMario commented Dec 23, 2024

Do we... need a step between "jug" and "keg", or do we just... put kegs into the dispenser?

I mean, there comes a point at which you become needlessly granular.

@MagnusCrowe
Copy link
Contributor

MagnusCrowe commented Dec 23, 2024

Kegs are for drinks.

image

@GreyMario
Copy link
Contributor

Kegs are for reagents; no sense declaring that there's an actual functional difference between the 600u container full of space cola and the 600u container full of potassium.

@southbridge-fur
Copy link
Contributor

I personally love this idea. It's a decent way to alleviate some of the various pain points discussed in the ongoing Chemmaster rework discussions without being a massive overhaul. I do agree that this should be a separate entity from the usual jugs, cost twice as much in resources, and be two-handed.

@dvir001
Copy link
Contributor

dvir001 commented Dec 23, 2024

Kegs are for reagents; no sense declaring that there's an actual functional difference between the 600u container full of space cola and the 600u container full of potassium.

DeltaV-Station/Delta-v#2378

Soon

Consider the metal drum barrels that were added as the replacer.

@GreaseMonk
Copy link
Contributor

GreaseMonk commented Dec 29, 2024

Jug but two handed , kinda like keg, but jug. I'll dig it. Definitely new item

@dustylens
Copy link
Contributor Author

Hmm. Bigger jugs. Keg jugs? Kugs? That seems interesting and good.

@dustylens dustylens changed the title Doubles default jug storage. Adds reinforced jug Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

RSI Diff Bot; head commit 23e065e merging into 78a4933
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Specific/Chemistry/reinforced_jug.rsi

State Old New Status
icon Added
inhand-left-fill-1 Added
inhand-left-fill-2 Added
inhand-left-fill-3 Added
inhand-left-fill-4 Added
inhand-left-fill-5 Added
inhand-left Added
inhand-right-fill-1 Added
inhand-right-fill-2 Added
inhand-right-fill-3 Added
inhand-right-fill-4 Added
inhand-right-fill-5 Added
inhand-right Added
jug1 Added
jug2 Added
jug3 Added
jug4 Added
jug5 Added
jug6 Added
stopper Added

Edit: diff updated after 23e065e

@dustylens dustylens marked this pull request as ready for review January 1, 2025 17:53
@dustylens
Copy link
Contributor Author

I did a little tinkering based on feedback.

Reverted the original jug change.
Added a new big reinforced jug w/ states etc.
Updated the dispenser inventory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants