Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambition Directional fans (and sink) #2309

Closed

Conversation

blackknight954
Copy link
Contributor

@blackknight954 blackknight954 commented Oct 23, 2024

About the PR

Replaced the tiny fans on the Ambition with directional fans, Added a sink to the janitor closet to provide a source of water (There were previously none)

Why / Balance

Keeping ships up to regulation, providing water for a ship with no water

How to test

Load a server,
Load the Ambition
Observe the changes

Media

image

Requirements

Breaking changes

N/A
Changelog
🆑

  • tweak: Swapped tiny fans for directional fans on all entrances of the Ambition, added a sink.

@github-actions github-actions bot added the No C# label Oct 23, 2024
@github-actions github-actions bot added the YML label Oct 23, 2024
@blackknight954 blackknight954 changed the title Ambition Directional fans Ambition Directional fans (and sink) Oct 23, 2024
@dvir001
Copy link
Contributor

dvir001 commented Oct 23, 2024

Changelog is broken, use the format, no more then one line also

File is not right place.

You left tiny fans

@dvir001 dvir001 added S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE labels Oct 23, 2024
@blackknight954 blackknight954 marked this pull request as draft October 23, 2024 17:51
@github-actions github-actions bot added the Map-Shuttle Map - Shuttle label Oct 23, 2024
@blackknight954 blackknight954 marked this pull request as ready for review October 23, 2024 18:39
@blackknight954
Copy link
Contributor Author

Changelog is broken, use the format, no more then one line also

File is not right place.

You left tiny fans

I believe it's all fixed, albeit I do not know if there is a way to mention the addition of the sink in the changelog without making a new PR for it, but if not, I can't really do much about it

@dvir001 dvir001 added S: Needs Review This PR is awaiting reviews and removed S: Awaiting Changes This PR has changes that need to be made before merging S: DO NOT MERGE labels Oct 27, 2024
@dustylens
Copy link
Contributor

It looks like the tiny fans have indeed been replaced with directional fans.

However while you're performing a compliance pass the loose AME fuel in the reactor room should be nixed and an AME fuel wall locker added in its place. In addition, so near as I can tell with this nightmare, the ship's atmos are lacking the compliance pass for an n2/o2 mixture and that should be added in.

@blackknight954
Copy link
Contributor Author

After learning that I accidently "Crossed wires" with some of my branches so to speak, bumping this to ensure that it is fine to be merged and not cause any issues

@blackknight954
Copy link
Contributor Author

Redoing changes to fix some file conflicts I found, will reupload soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants