-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liquidator Shuttle (Rework) #2288
Open
ErhardSteinhauer
wants to merge
10
commits into
new-frontiers-14:master
Choose a base branch
from
ErhardSteinhauer:2024-10-lvhi-liquidator-rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Liquidator Shuttle (Rework) #2288
ErhardSteinhauer
wants to merge
10
commits into
new-frontiers-14:master
from
ErhardSteinhauer:2024-10-lvhi-liquidator-rework
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Docs
Improvements or additions to documentation
Map-Shuttle
Map - Shuttle
No C#
Sprites
labels
Oct 19, 2024
ErhardSteinhauer
added
the
Ship Contribution Freeze
In effect from 2024-10-14 'til it ends, see https://discord.com/channels/1123826877245694004/1129270
label
Nov 3, 2024
github-actions
bot
added
the
S: Merge Conflict
This PR has conflicts that prevent merging
label
Nov 18, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
S: Merge Conflict
This PR has conflicts that prevent merging
label
Dec 8, 2024
I love this lil guy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Docs
Improvements or additions to documentation
Map-Shuttle
Map - Shuttle
No C#
S: Needs Review
This PR is awaiting reviews
Ship Contribution Freeze
In effect from 2024-10-14 'til it ends, see https://discord.com/channels/1123826877245694004/1129270
Sprites
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Reworked and repurposed towards salvaging/recycling(/shipbreaking?) LVHI Liquidator shuttle. For intended new game loop (fly to space wreck, chuck absolutely every single item on it to the belt, extract materials) heavily dependent on #2179.
Why / Balance
Last ditch attempt at saving Liquidator shuttle: janitorial gameplay isn't there to warrant relatively big and expensive shuttle like Liquidator, so it's either this or retirement for the shuttle in question.
How to test
Spawn, buy, fly.
Media
Requirements
Breaking changes
Changelog
🆑 erhardsteinhauer