Update the Rspec::Parser to ignore simplecov output mixed into the rspec json #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplecov-html
, the default simplecov output formatter, dumps text output into stderr even when rspec is asked for--format json
, causing the output stream to be unparseable. While this is truly an issue withsimplecov
(and I've started a conversation here), we can work around it from our end because the text being written into the output stream is very limited and specific.So - as part of parsing the output of rspec, look for non-json simplecov output strings and strip them from the text before json-parsing.
You can actually produce this error on this repository in
main
by runningSIMPLECOV=true bin/qq
, which totally passes in this branch ;-)