-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cron job to periodically purge #31
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #31 +/- ##
==========================================
+ Coverage 86.75% 90.00% +3.24%
==========================================
Files 12 10 -2
Lines 317 310 -7
==========================================
+ Hits 275 279 +4
+ Misses 42 31 -11 ☔ View full report in Codecov by Sentry. |
codecov patch only failing because we don't have tests for migrations. (should we?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👌
We should test the migration in the test env to make sure that the app works as before after the changed primary key field type.
Maybe we can configure the code coverage to exclude migrations in the future |
oh that's a good idea, I'll look at how to exclude folders! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Now the PR instead increases the code coverage 😁
Short description of the changes:
Add a monthly cron job to purge expired data
Long description of the changes:
purge_expired_data
command/var/log/cron.log
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References