Update tests and remove unused code #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #18 +/- ##
===========================================
+ Coverage 76.82% 86.95% +10.13%
===========================================
Files 10 10
Lines 302 276 -26
===========================================
+ Hits 232 240 +8
+ Misses 70 36 -34 ☔ View full report in Codecov by Sentry. |
backmari
approved these changes
Jun 25, 2024
| else: | ||
| raise PermissionDenied | ||
| return HttpResponse(status=401) |
|
|
||
| def test_session(self): | ||
| # once you authenicate once with username and password you should be able to reuse the session with credentials | ||
| session = requests.Session() |
There was a problem hiding this comment.
cool, I didn't know it worked with sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref 5462: LiveDataServer: Enhance (Add) Tests
This adds tests to cover all the endpoints used.
I removed the endpoint
/plots/$instrument/$run_number/as it was not used by anything that I know of. It also included an old version of jquery with known vulnerabilities so nobody should be using it.I also did a small amount of code improvements as I seen things.
Short description of the changes:
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References