Chore: keep dex message evts [NTRN-439] #277
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/app.go
Outdated
| for _, m := range app.ModuleManager.Modules { | ||
| if moduleWithName, ok := m.(module.HasName); ok { | ||
| moduleName := moduleWithName.Name() | ||
| if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
| modules[moduleName] = appModule | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
app/app.go
Outdated
| for _, key := range app.keys { | ||
| keys = append(keys, key) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
app/app.go
Outdated
| for acc := range GetMaccPerms() { | ||
| modAccAddrs[authtypes.NewModuleAddress(acc).String()] = true | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
tests/system/cli.go
Outdated
| go func(i int) { // do parallel | ||
| c.t.Logf("Voting: validator %d\n", i) | ||
| rsp = c.CustomCommand("tx", "gov", "vote", ourProposalID, "yes", "--from", c.GetKeyAddr(fmt.Sprintf("node%d", i))) | ||
| RequireTxSuccess(c.t, rsp) | ||
| }(i) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note test
tests/system/system.go
Outdated
| panic(fmt.Sprintf("stderr reader error %#+v", err)) | ||
| } | ||
| stopRingBuffer := make(chan struct{}) | ||
| go appendToBuf(io.TeeReader(errReader, logfile), s.errBuff, stopRingBuffer) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note test
x/wasm/ibctesting/events.go
Outdated
| for eventName, hasEvent := range hasEvents { | ||
| suite.Require().True(hasEvent, "event: %s was not found in events", eventName) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
x/wasm/keeper/keeper.go
Outdated
| "fmt" | ||
| "math" | ||
| "path/filepath" | ||
| "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
x/wasm/keeper/options.go
Outdated
| @@ -2,9 +2,12 @@ | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| "reflect" | |||
Check notice
Code scanning / CodeQL
Sensitive package import Note
x/wasm/keeper/test_common.go
Outdated
| maccPerms, | ||
| authcodec.NewBech32Codec(sdk.Bech32MainPrefix), |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
x/wasm/keeper/test_common.go
Outdated
| maccPerms, | ||
| authcodec.NewBech32Codec(sdk.Bech32MainPrefix), | ||
| sdk.Bech32MainPrefix, |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
Don't filter dex events. When dex messages are dispatched from CW contracts the "message" events are filtered out. These events must be emitted for proper dex indexing.