NTRN-383 revision number and height in query #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasisamurai
changed the base branch from
main
to
neutron_audit_informal_17_01_2023
quasisamurai
changed the title
pr0n00gler
requested changes
Mar 17, 2023
x/interchainqueries/keeper/keeper.go
Outdated
| // to avoid nil in neutron, null in json and rust marshalling errors, here we initialize it with "default" values | ||
| // which is not equal 0 because github.com/cosmos/cosmos-sdk/codec/types skips true default values | ||
| emptyHeight := ibcclienttypes.NewHeight(1, 1) | ||
| if query.LastSubmittedResultRemoteHeight == nil { |
There was a problem hiding this comment.
Why not just to use Option<u64> on sc level?
There was a problem hiding this comment.
if you meant Option<Height>, I believe couple of simple lines in neutron node is a bit preferable than unnecessary complications in our smart contracts, also we should init this struct anyway (in other place), even w Option
x/interchainqueries/keeper/keeper.go
Outdated
Comment on lines
258
to
261
| if query.LastSubmittedResultRemoteHeight.RevisionNumber < height.GetRevisionNumber() { | ||
| return nil | ||
| } else if query.LastSubmittedResultRemoteHeight.RevisionHeight >= height.GetRevisionHeight() && | ||
| query.LastSubmittedResultRemoteHeight.RevisionNumber == height.GetRevisionNumber() { |
There was a problem hiding this comment.
ibcclienttypes.Height has all the necessary methods to compare two structs (LTE, GTE, etc).
…mber-and-height # Conflicts: # x/interchainqueries/types/genesis.pb.go
quasisamurai
force-pushed
the
fix/revision-number-and-height
branch
from
3858936
to
e01e41d
Compare
|
Talked to @swelf19, going too try smth to make it look a bit better |
quasisamurai
force-pushed
the
fix/revision-number-and-height
branch
from
5c82cbe
to
999d7d8
Compare
swelf19
previously approved these changes
Mar 21, 2023
pr0n00gler
previously approved these changes
Mar 21, 2023
quasisamurai
changed the base branch from
neutron_audit_informal_17_01_2023
to
main
quasisamurai
dismissed stale reviews from pr0n00gler and swelf19
The base branch was changed.
pr0n00gler
approved these changes
Mar 21, 2023
swelf19
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK
TEST
There are bunch of PRs: