-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fee in example contracts #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxpy
force-pushed
the
fix/example-contracts-fee
branch
from
March 20, 2023 12:10
ce84ae1
to
a57fe4e
Compare
quasisamurai
previously approved these changes
Mar 20, 2023
sotnikov-s
requested changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts doesn't work:
++ neutrond tx wasm store ../artifacts/ibc_transfer.wasm --from demowallet1 -y --chain-id test-1 --gas 50000000 --gas-prices 0.0025untrn --broadcast-mode=block --keyring-backend=test --output json --home ../../neutron/data/test-1/ --node tcp://127.0.0.1:16657
++ jq -r '.logs[0].events[] | select(.type == "store_code").attributes[] | select(.key == "code_id").value'
...
invalid Bech32 prefix; expected cosmos, got neutron: invalid request
+ code_id=
seems like the nodes ports are not as expected
sotnikov-s
requested changes
Mar 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts doesn't work:
++ neutrond tx wasm store ../artifacts/ibc_transfer.wasm --from demowallet1 -y --chain-id test-1 --gas 50000000 --gas-prices 0.0025untrn --broadcast-mode=block --keyring-backend=test --output json --home ../../neutron/data/test-1/ --node tcp://127.0.0.1:16657
++ jq -r '.logs[0].events[] | select(.type == "store_code").attributes[] | select(.key == "code_id").value'
...
invalid Bech32 prefix; expected cosmos, got neutron: invalid request
+ code_id=
seems like the nodes ports are not as expected
foxpy
force-pushed
the
fix/example-contracts-fee
branch
from
March 28, 2023 08:39
a57fe4e
to
432ecef
Compare
foxpy
force-pushed
the
fix/example-contracts-fee
branch
2 times, most recently
from
March 29, 2023 08:40
4c892f1
to
d6c3283
Compare
foxpy
force-pushed
the
fix/example-contracts-fee
branch
from
March 29, 2023 08:49
d6c3283
to
4a464b4
Compare
sotnikov-s
previously approved these changes
Mar 29, 2023
sotnikov-s
approved these changes
Apr 4, 2023
zavgorodnii
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes bash test scripts and makes them more beautiful. Try them out!
It is currently a little tricky to test because of issues in ICQ relayer, which I didn't fix yet (I will do that later).
Instructions:
make init && make start-rly
, wait until hermes starts printing messages like these:.env
contents with following lines:export $(grep -v '^#' .env | xargs) && make dev
make build
./test_ibc_transfer.sh
,./test_interchain_txs.sh
,./test_kv_query.sh
and finally./test_tx_query.sh
. Do not restart relayer or node between tests, or you will trigger bugs in ICQ relayer. Once again, I will fix these bugs soon…Don't worry, these tests are designed to be run individually, I am asking you to run them in exact order only because of bugs in ICQ relayer.