Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new transaction filter #60

Merged

Conversation

ratik
Copy link
Contributor

@ratik ratik commented Nov 10, 2022

@ratik ratik marked this pull request as ready for review November 10, 2022 10:01
@pr0n00gler
Copy link
Collaborator

Are there any scripts/tests to check this actually works?

@swelf19
Copy link
Contributor

swelf19 commented Nov 16, 2022

We could check, the new query data corresponds the query type

@ratik
Copy link
Contributor Author

ratik commented Nov 16, 2022

We could check, the new query data corresponds the query type

I'm afraid we don't have info what kind of query we updating in this case so we can't check it this way

@ratik
Copy link
Contributor Author

ratik commented Nov 16, 2022

Are there any scripts/tests to check this actually works?

not yet, will do

Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. what about integration tests for this feature?

upd: ignore — I can see the comment above. waiting for the test before I approve

…on-org/neutron-contracts into feat/new_transaction_filter
@zavgorodnii zavgorodnii merged commit 17f469b into neutron_audit_oak_19_09_2022_fixes Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants