-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/new transaction filter #60
Feat/new transaction filter #60
Conversation
…on-org/neutron-contracts into feat/new_transaction_filter
Are there any scripts/tests to check this actually works? |
We could check, the new query data corresponds the query type |
I'm afraid we don't have info what kind of query we updating in this case so we can't check it this way |
not yet, will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. what about integration tests for this feature?
upd: ignore — I can see the comment above. waiting for the test before I approve
…on-org/neutron-contracts into feat/new_transaction_filter
https://p2pvalidator.atlassian.net/browse/NTRN-262