Merge pull request #5 from neutron-org/fix/slashing-bitmap-migration-key

fix: fixed key in slashing bitmap migration
neutron-org · Oct 9, 2023 · fcccb9a · fcccb9a
2 parents efa6493 + 8f3a2ad
commit fcccb9a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/x/slashing/migrations/v4/keys.go b/x/slashing/migrations/v4/keys.go
@@ -9,8 +9,6 @@ import (
 )
 
 const (
-	addrLen = 20
-
 	MissedBlockBitmapChunkSize = 1024 // 2^10 bits
 )
 
@@ -32,7 +30,7 @@ func ValidatorSigningInfoAddress(key []byte) (v sdk.ConsAddress) {
 }
 
 func validatorMissedBlockBitArrayPrefixKey(v sdk.ConsAddress) []byte {
-	return append(validatorMissedBlockBitArrayKeyPrefix, v.Bytes()...)
+	return append(validatorMissedBlockBitArrayKeyPrefix, address.MustLengthPrefix(v.Bytes())...)
 }
 
 func ValidatorMissedBlockBitArrayKey(v sdk.ConsAddress, i int64) []byte {

diff --git a/x/slashing/migrations/v4/migrate_test.go b/x/slashing/migrations/v4/migrate_test.go
@@ -40,10 +40,6 @@ func TestMigrate(t *testing.T) {
 	err := v4.Migrate(ctx, cdc, store, params)
 	require.NoError(t, err)
 
-	// ensure old entries no longer exist and new bitmap chunk entries exist
-	entries := v4.GetValidatorMissedBlocks(ctx, cdc, store, consAddr, params)
-	require.Empty(t, entries)
-
 	for i := int64(0); i < params.SignedBlocksWindow; i++ {
 		chunkIndex := i / v4.MissedBlockBitmapChunkSize
 		chunk := store.Get(v4.ValidatorMissedBlockBitmapKey(consAddr, chunkIndex))