GFX: selectable lossy compression levels #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalefty
force-pushed
the
compression-level-options
branch
from
3313486
to
e3c83c5
Compare
|
There is room to adjust quantization values but this one can be merged. |
|
This looks good to me, maybe a rebase first. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboot of #2539. This feature is also requested by @unstabler and another enterprise user.
Classic RemoteFX requires connectionType==LAN so we can't use the parameter to adjust compression level. In contrast, GFX can be used whatever value connectionType is set to. Therefore, we can use this parameter to tell the encoder compression level.
This is still a proof of concept so this PR is a draft.
Ultra Low Quality
Low Quality
Standard Quality