Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Use the Resolve API to define ResolveLoader according to webpack #99

Merged

Conversation

eliperelman
Copy link
Member

According to the webpack docs:

This set of options is identical to the resolve property set above, but is used only to resolve webpack's loader packages.

This tells me that the Resolve API and the ResolveLoader API should actually be identical. According to the webpack schema, both resolve and resolveLoader are ref'd to the resolve definition:

https://github.com/webpack/webpack/blob/dfe6379052598a00f13bfa4f34ac73856ddf3dd0/schemas/WebpackOptions.json#L1668

This should not be breaking at all, and should only be a feature bump due to the addition of the resolve methods. The only reason we aren't just new-ing a Resolve in Config is that there are some legacy methods that would cause a breaking change if removed.

Fixes #97.

@eliperelman eliperelman requested a review from edmorley September 5, 2018 18:47
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some of the test/Resolve.js tests to test/ResolveLoader.js? :-)

@eliperelman eliperelman requested a review from edmorley September 6, 2018 17:06
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eliperelman eliperelman merged commit e4d43b5 into neutrinojs:master Sep 6, 2018
@eliperelman
Copy link
Member Author

Released in v4.10.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

How do you specify resolveLoader.alias?
2 participants