Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

test: 'clean' in 'ChainedMap' #93

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Conversation

ulivz
Copy link
Contributor

@ulivz ulivz commented Aug 22, 2018

No description provided.

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this! I just have one request to fix and I think we can merge this.

map.set('alpha', {});
t.true('alpha' in map.entries());
t.false('alpha' in map.clean(map.entries()));
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you insert a blank line at the end of this file? This is why travis is failing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me and fixed at e2d8d50

Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@edmorley edmorley merged commit 04eebb9 into neutrinojs:master Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants