This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Migrate to new org #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
suggested changes
Aug 21, 2018
eliperelman
force-pushed
the
org-rename
branch
from
060c4c7 to
c5423d1
Compare
edmorley
approved these changes
Aug 22, 2018
README.md
Outdated
| @@ -915,7 +923,9 @@ config.module | |||
| config.module | |||
| .rule('compile') | |||
| .use('babel') | |||
| .tap(options => merge(options, { plugins: ['babel-plugin-syntax-object-rest-spread'] })); | |||
| .tap(options => merge(options, { | |||
| plugins: ['babel-plugin-syntax-object-rest-spread'] | |||
There was a problem hiding this comment.
While we're here, let's change this to the new style scoped package names, and also something that isn't already handled by @babel/preset-env. Perhaps @babel/plugin-proposal-class-properties?
| @@ -18,7 +18,7 @@ | |||
| "scripts": { | |||
| "test": "ava test", | |||
| "lint": "eslint src test .eslintrc.js", | |||
| "changelog": "changelog mozilla-neutrino/webpack-chain all --markdown > CHANGELOG.md" | |||
| "changelog": "changelog neutrinojs/webpack-chain all --markdown > CHANGELOG.md" | |||
There was a problem hiding this comment.
Could you also regenerate CHANGELOG.md so it picks up the new repo URL?
eliperelman
force-pushed
the
org-rename
branch
from
d14e49c to
fac2d43
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.