Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Expose toString as a static method on Config #57

Merged
merged 1 commit into from
May 16, 2018

Conversation

yyx990803
Copy link
Contributor

@yyx990803 yyx990803 commented May 16, 2018

In Vue CLI we allow users to perform manipulations on the generated raw webpack config (in addition to chain-style modifications), and with the current implementation we cannot reuse the toString logic.

Making toString a static method that accepts the config allows us to apply user modifications before stringifying the config.

@edmorley edmorley requested a review from eliperelman May 16, 2018 20:54
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git whitespace changes threw me for a second, but everything seems A-OK. Thank you so much!

@eliperelman eliperelman merged commit 0823a1e into neutrinojs:master May 16, 2018
@yyx990803
Copy link
Contributor Author

Thanks, would appreciate a new release next few days so we can use the now built-in toString in Vue CLI!

@eliperelman
Copy link
Member

Released in v4.8.0.

cc: @yyx990803

@yyx990803
Copy link
Contributor Author

🎉 thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants